Skip to content

{tools} [GCCcore/6.4.0] libssh v0.9.0 {REVIEW}#8865

Merged
smoors merged 2 commits intoeasybuilders:developfrom
SimonPinches:libssh
Oct 10, 2019
Merged

{tools} [GCCcore/6.4.0] libssh v0.9.0 {REVIEW}#8865
smoors merged 2 commits intoeasybuilders:developfrom
SimonPinches:libssh

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

@SimonPinches SimonPinches commented Aug 30, 2019

No description provided.

Micket
Micket requested changes Sep 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a second opinion on this; Do we even want libssh as a module, or do we prefer relying on OS to keep it in regards to security updates? Perhaps it's enough to keep openssl as OS level.

Comment thread easybuild/easyconfigs/l/libssh/libssh-0.9.0-GCCcore-6.4.0.eb
@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Sep 10, 2019

I'm for keeping things like this out of EB and relying on OS builds due to the frequent security updates.

@boegel boegel added the new label Sep 11, 2019
@boegel boegel added this to the 4.x milestone Sep 11, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2019

We have easyconfig files for OpenSSL too, but we actively discourage using them to resolve dependencies.

I think it's OK to add an easyconfig for this, it could help people that don't have admin access to install a missing dep?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 9, 2019

Test report by @smoors
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node353.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/59156ab53d1f20c1219edfdc463c5cf5 for a full test report.

smoors
smoors approved these changes Oct 10, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors requested a review from Micket October 10, 2019 14:57
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 10, 2019

Going in, thanks @SimonPinches!

@smoors smoors merged commit c1c4f38 into easybuilders:develop Oct 10, 2019
@boegel boegel modified the milestones: 4.x, next release (4.0.1) Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@SimonPinches @akesandgren @boegel @smoors @Micket