Skip to content

fix permissions for TRF#9034

Merged
boegel merged 3 commits intoeasybuilders:developfrom
smoors:20190929222424_new_pr_TRF409
Sep 30, 2019
Merged

fix permissions for TRF#9034
boegel merged 3 commits intoeasybuilders:developfrom
smoors:20190929222424_new_pr_TRF409

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Sep 29, 2019

(created using eb --new-pr)

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Sep 29, 2019

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node360.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/51b4e083e850d244a36b213cc75a31f8 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/4a714ee2b300c58a46616a2c609ac25d for a full test report.

@boegel boegel added the bug fix label Sep 30, 2019
@boegel boegel added this to the next release (4.0.1) milestone Sep 30, 2019
@easybuilders easybuilders deleted a comment from boegelbot Sep 30, 2019
@migueldiascosta
Copy link
Copy Markdown
Member

@smoors what about adding something like

sanity_check_commands = ["trf --help 2>&1 | grep 'Please use: trf File'"]

(trf --help alone won't work because it returns a non-zero exit status)

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 30, 2019

+1 on the custom sanity check command (and you can drop --help if it's not a known option, just trf | grep ... is fine I think)

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Sep 30, 2019

good idea, might as well do a real test.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Sep 30, 2019

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node320.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/394b9137e7791d62c1355a49c8ddd21f for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Sep 30, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 30, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3116.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/72f7545c2c97e4d9c1b5fcb4ad3b6873 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 30, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2065.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4c2b329373d4358f2cfa972b1ee8aea5 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@easybuilders easybuilders deleted a comment from boegelbot Sep 30, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 30, 2019

Going in, thanks @smoors!

@boegel boegel merged commit 4f59405 into easybuilders:develop Sep 30, 2019
@smoors smoors deleted the 20190929222424_new_pr_TRF409 branch January 15, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants