Skip to content

add patch from #5829 to pigz easyconfig#9138

Merged
verdurin merged 3 commits intoeasybuilders:developfrom
migueldiascosta:20191016111439_new_pr_pigz24
Nov 11, 2019
Merged

add patch from #5829 to pigz easyconfig#9138
verdurin merged 3 commits intoeasybuilders:developfrom
migueldiascosta:20191016111439_new_pr_pigz24

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Oct 16, 2019

(created using eb --new-pr)

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Oct 16, 2019

so that we can close #5829

@migueldiascosta migueldiascosta added this to the next release (4.1.0?) milestone Oct 16, 2019
@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Oct 16, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/1948926f50d26715a70d555edff9912d for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 10, 2019

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.7.1908, Intel Xeon Processor (Skylake, IBRS), Python 2.7.5
See https://gist.github.com/087aaddb094267bd01c94f1f55e60f77 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 10, 2019

@migueldiascosta Are you up for applying these fixes to the other recent pigz versions too?

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Nov 11, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/594fb1869e79b17da3f6846b022c8ba0 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 11, 2019

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (4 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.7.1908, Intel Xeon Processor (Skylake, IBRS), Python 2.7.5
See https://gist.github.com/f6316f4d5966e76c8c166281311396bc for a full test report.

verdurin
verdurin approved these changes Nov 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 11, 2019

Going in, thanks @migueldiascosta!

@verdurin verdurin merged commit c5a9bed into easybuilders:develop Nov 11, 2019
@migueldiascosta migueldiascosta mentioned this pull request Nov 11, 2019
Closed
@easybuilders easybuilders deleted a comment from boegelbot Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@migueldiascosta @verdurin