Skip to content

add missing setuptools_scm extension required to build dateutil extension in Python 3.7.0 easyconfigs#9209

Merged
boegel merged 3 commits intoeasybuilders:developfrom
arielzn:20191025001800_new_pr_Python370
Nov 5, 2019
Merged

add missing setuptools_scm extension required to build dateutil extension in Python 3.7.0 easyconfigs#9209
boegel merged 3 commits intoeasybuilders:developfrom
arielzn:20191025001800_new_pr_Python370

Conversation

@arielzn
Copy link
Copy Markdown
Contributor

@arielzn arielzn commented Oct 24, 2019

(created using eb --new-pr)

Micket
Micket previously approved these changes Oct 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 29, 2019

@arielzn Can you submit a test report?

@arielzn
Copy link
Copy Markdown
Contributor Author

arielzn commented Oct 30, 2019

Test report by @arielzn
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
dragon2-ctrl0.umons.ac.be - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 2.7.5
See https://gist.github.com/e12c236d44e69da3b778f55fc257549c for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Nov 4, 2019
@boegel boegel added the bug fix label Nov 4, 2019
@boegel boegel added this to the next release (4.0.2?) milestone Nov 4, 2019
boegel
boegel requested changes Nov 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielzn To keep things consistent, the same fix should be applied to the other easyconfigs for Python 3.7.0 (Python-3.7.0-intel-2018b.eb and Python-3.7.0-iomkl-2018b.eb).

Can you make that change? I can provide a full test report afterwards...

@arielzn
Copy link
Copy Markdown
Contributor Author

arielzn commented Nov 5, 2019

@boegel sure, i can add those.

@boegel boegel changed the title add missing setuptools_scm extension required to build dateutil extension add missing setuptools_scm extension required to build dateutil extension in Python 3.7.0 easyconfigs Nov 5, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 5, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3141.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/ea144d2db837a620d157176a4202701c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 5, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2401.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/cd1ed0952fbd508566e185627adc2c49 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 5, 2019

Going in, thanks @arielzn!

@boegel boegel merged commit f240aed into easybuilders:develop Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@Micket Micket Micket left review comments

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@arielzn @Micket @boegel