Skip to content

ignore commented out lines in easyconfig files when checking for http:// URLs#9224

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:https_commented
Nov 5, 2019
Merged

ignore commented out lines in easyconfig files when checking for http:// URLs#9224
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:https_commented

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 4, 2019

fixes #9180 reported by @paulmelis

Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 5, 2019

@boegel Haven't tested it though?

Comment thread test/easyconfigs/easyconfigs.py
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 5, 2019

@verdurin This is hard to test without it being merged. I plan to re-trigger the tests in #9217 once this is merged to confirm the fix.

@akesandgren akesandgren dismissed their stale review November 5, 2019 07:18

Too hard to do at the moment, this works as a stopgap...

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit fd767b8 into easybuilders:develop Nov 5, 2019
@boegel boegel deleted the https_commented branch November 5, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTPS URL check should ignore commented lines

3 participants