Skip to content

{bio}[foss/2018b] CITE-seq-Count v1.4.3 w/ Python 3.6.6#9237

Merged
smoors merged 12 commits intoeasybuilders:developfrom
timeu:20191108092124_new_pr_CITE-seq-Count143
Nov 13, 2019
Merged

{bio}[foss/2018b] CITE-seq-Count v1.4.3 w/ Python 3.6.6#9237
smoors merged 12 commits intoeasybuilders:developfrom
timeu:20191108092124_new_pr_CITE-seq-Count143

Conversation

@timeu
Copy link
Copy Markdown
Contributor

@timeu timeu commented Nov 8, 2019

(created using eb --new-pr)

@timeu timeu requested a review from verdurin November 11, 2019 10:37
@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
FAILED
Build succeeded for 2 out of 4 (3 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.7.1908, Intel Xeon Processor (Skylake, IBRS), Python 2.7.5
See https://gist.github.com/6f273f4026c6152ff17ef969fbbb4395 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

@timeu Here's the specific error:

== 2019-11-11 14:10:22,855 build_log.py:164 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:124 in __init__): Sanity check failed: no (non-empty) directory found at 'lib/python3.6/site-packages/python_Levenshtein-0.12.0-py3.6-linux-x86_64.egg' in /eb/maint/software/python-Levenshtein/0.12.0-foss-2018b-Python-3.6.6 (at easybuild/framework/easyblock.py:2585 in _sanity_check_step)
== 2019-11-11 14:10:22,855 easyblock.py:3082 WARNING build failed (first 300 chars): Sanity check failed: no (non-empty) directory found at 'lib/python3.6/site-packages/python_Levenshtein-0.12.0-py3.6-linux-x86_64.egg' in /eb/maint/software/python-Levenshtein/0.12.0-foss-2018b-Python-3.6.6
== 2019-11-11 14:10:22,855 easyblock.py:294 INFO Closing log for application name python-Levenshtein version 0.12.0

@easybuilders easybuilders deleted a comment from boegelbot Nov 12, 2019
@easybuilders easybuilders deleted a comment from boegelbot Nov 12, 2019
@easybuilders easybuilders deleted a comment from boegelbot Nov 12, 2019
@easybuilders easybuilders deleted a comment from boegelbot Nov 12, 2019
boegel
boegel previously requested changes Nov 12, 2019

toolchain = {'name': 'foss', 'version': '2018b'}


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timeu Please remove duplicate empty line

@boegel boegel added the new label Nov 12, 2019
@boegel boegel added this to the 4.x milestone Nov 12, 2019
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 13, 2019

Test report by @smoors
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in this PR)
node251.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz, Python 2.7.5
See https://gist.github.com/beedec0f1d828a3e361317b8fcf3bebd for a full test report.

@timeu
Copy link
Copy Markdown
Contributor Author

timeu commented Nov 13, 2019

@smoors: Thanks for the test.
I forgot to add the pytest dependency which I fixed in the last commit. Can you give it another try ?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 13, 2019

Test report by @smoors
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node217.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz, Python 2.7.5
See https://gist.github.com/849d5e37e0c8b7a8cc24c40c0d5f2a6a for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 13, 2019

@timeu the checks failed because PSI4 and ProjectQ depend on pytest-3.8.2, so you should use the same version for CITE-seq-Count.

@timeu
Copy link
Copy Markdown
Contributor Author

timeu commented Nov 13, 2019

@smoors : Hmm I see but in there is only a pytest-3.8.2-foss-2017b-Python-3.6.3.eb (2017b) toolchain.
There is a pytest-4.3.0-foss-2018b-Python-3.6.6.eb easyconfig.
So this means I would have to create a pytest-3.8.2-foss-2018b-Python-3.6.3.eb version ?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 13, 2019

@timeu yes, unfortunately (but using Python-3.6.6). the alternative is to add pytest and all its deps to the extensions list.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 13, 2019

Test report by @smoors
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node251.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz, Python 2.7.5
See https://gist.github.com/da3293f6d8e643a827e83eb9775d0f5e for a full test report.

@smoors smoors dismissed stale reviews from boegel and verdurin November 13, 2019 14:46

changes addressed

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added the update label Nov 13, 2019
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 13, 2019

Going in, thanks @timeu!

@smoors smoors merged commit 36310e3 into easybuilders:develop Nov 13, 2019
@easybuilders easybuilders deleted a comment from boegelbot Nov 14, 2019
@boegel boegel modified the milestones: 4.x, 4.1.0 Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants