Skip to content

fix checking of files changed by PR in GitHub Actions context#9255

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:github_pr_changed_files
Nov 12, 2019
Merged

fix checking of files changed by PR in GitHub Actions context#9255
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:github_pr_changed_files

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 11, 2019

Tests failed in Travis CI in #9251 because of missing versionsuffix, but passed in GitHub's native CI because test_changed_files_pull_request was basically being skipped in GitHub Actions context...

This change should fix that.

@boegel boegel added the bug fix label Nov 11, 2019
@boegel boegel added this to the next release (4.0.2?) milestone Nov 11, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 11, 2019

The List of changed easyconfig files in this PR: that appears in the log for the GitHub CI runs shows that the fix works...

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 52ad636 into easybuilders:develop Nov 12, 2019
@boegel boegel deleted the github_pr_changed_files branch November 12, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants