You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I could need some guidance on this one. Is modaliases the way to go here? Is a sanity_check_commands with maxquantcmd --help helpful? (I tried this but the alias doesn't seem to be known during the sanity check) Should source_urls be removed because you need to register and get a link with some hash and an expiration date so a normal download will fail due to error 403?
@SethosIImodaliases is indeed fine here.
modaliases are only added to the module file, so if you want sanity_check_commands you need to specify the full command (you could define a local_* variable to avoid having to type it twice). source_urls should indeed be removed.
Test report by @smoors SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node353.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/d29da23d61aef2902eee4a71fcc6ff0a for a full test report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
#9102I could need some guidance on this one. Is
modaliasesthe way to go here?Is a(I tried this but the alias doesn't seem to be known during the sanity check) Shouldsanity_check_commandswithmaxquantcmd --helphelpful?source_urlsbe removed because you need to register and get a link with some hash and an expiration date so a normal download will fail due to error 403?