{bio}[foss/2019a] Reapr v1.0.18#9296
Conversation
…s: Reapr-1.0.18-cleanup.patch
| exts_defaultclass = 'PerlModule' | ||
|
|
||
| exts_list = [ | ||
| ('File::Spec::Link', '0.140', { |
There was a problem hiding this comment.
Maybe we should add this to the Perl easyconfig instead?
There was a problem hiding this comment.
BTW. I had to tell another user that needed "Palavras", how she could install the Perl libraries "DB_File" and "MLDBM::Sync" in her home-dir.
| +++ Reapr_1.0.18/Makefile 2019-11-13 12:17:03.000000000 +0100 | ||
| @@ -0,0 +1,8 @@ | ||
| +all: | ||
| + cd third_party/tabix ; make |
There was a problem hiding this comment.
tabix is provided by HTSlib, isn't adding that as a dependency a better alternative?
There was a problem hiding this comment.
The problem is this line in src/Makefile:
TABIX = tabix/tabix.o -L./tabix -ltabix -lz
Neither the tabix easyconfig nor the HTSLib easyconfig allows linking with the static tabix library file that is created during compilation. I don't know why the Makefile also links with tabix.o.
There was a problem hiding this comment.
I overlooked the explicit linking to tabix.o...
I can't think of a reason why that would be needed when also linking to -ltabix, but I guess this approach is the easiest way forward. It's not like tabix is a huge dependency, or that taking this approach would cause any major problems.
Plus, there's a whole bunch of (useful) patching going on here already, so not including this bit in the patch wouldn't prevent the need for a patch anyway.
|
(close/re-open to re-trigger CI tests and get a green light) |
|
Test report by @boegel |
|
Test report by @boegel |
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 680175948 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
@hrnagel My apologies for not getting back to this earlier, it slipped between the cracks despite your quick response to the initial review... It's good to go now, as soon as the test suite runs in CI give a green light I'll get this merged. |
|
Going in, thanks @hrnagel! |
(created using
eb --new-pr)