Skip to content

{tools}[GCCcore/8.3.0] hypothesis v4.44.2 w/ Python 3.7.4#9317

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
branfosj:20191116173309_new_pr_hypothesis4442
Nov 17, 2019
Merged

{tools}[GCCcore/8.3.0] hypothesis v4.44.2 w/ Python 3.7.4#9317
akesandgren merged 1 commit intoeasybuilders:developfrom
branfosj:20191116173309_new_pr_hypothesis4442

Conversation

@branfosj
Copy link
Copy Markdown
Member

(created using eb --new-pr)

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
bber0501u03a.bb2.cluster - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/15ea0711ef6640bb5f47ae8a65f68951 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
bear-pg0211u13a.bear.cluster - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz, Python 2.7.5
See https://gist.github.com/571c88b0f5c9e6060394e90050c2ca62 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
bb2c1a09.bb2.cluster - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz, Python 2.7.5
See https://gist.github.com/27e0b8ac130f58246c7c29ba40dea997 for a full test report.

smoors
smoors previously requested changes Nov 16, 2019

builddependencies = [('binutils', '2.32')]

dependencies = [('Python', '3.7.4')]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branfosj hypothesis still works with Python 2, no?
in that case please use multi_deps as was done for hypothesis-4.23.4-GCCcore-8.2.0.eb?
(see also the email of Kenneth to the mailing list from 1 day ago)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tried to multi_deps it and I'm hitting an odd error: https://gist.github.com/branfosj/61a8bf5135f2cc422c1f8d545b5da7f3

https://gist.github.com/branfosj/61a8bf5135f2cc422c1f8d545b5da7f3#file-easybuild-hypothesis-4-44-2-20191116-190723-sallh-log-L1124 shows: TypeError: attrs() got an unexpected keyword argument 'eq' which is unexpected. This feature got added to attrs in 19.2 but I'm using 19.3 here, which suggests that we're picking up the attrs 19.1 that is included in the Python 2.7.16 and 3.7.4 installs instead. However, this doesn't happen when I build the Python 3.7.4 specific hypothesis module.

And,

diff -r ../../../../../../EL7/EL7-cascadelake/software/hypothesis/4.44.2-GCCcore-8.3.0-Python-3.7.4/lib/python3.7/site-packages/ ../../../../../../EL7/EL7-cascadelake/software/hypothesis/4.44.2-GCCcore-8.3.0/lib/python3.7/site-packages/

shows that the two lib/python3.7/site-packages directories are identical.

I'm running at version 4.0.1 for framework, easyblocks, and easyconfigs.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't easily override a Python package from the Python installation when using multi_deps, we've run into that earlier this week for something else, basically because for multi_deps to work we don't use $PYTHONPATH but site.addsitedir, and apparently the latter only append, there is no way to prepend (see also https://bugs.python.org/issue7744).

So I guess we'll have to go forward with Python 3-only here.

Is this a dependency for something else?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started work on PyTorch 1.3.1 and this is for that. The pull requests I have done today are all in support of that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're stuck to a single Python version there anyway, due to SciPy-bundle, so OK.

@boegel boegel added the update label Nov 16, 2019
@boegel boegel added this to the 4.x milestone Nov 16, 2019
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel modified the milestones: 4.x, next release (4.1.0) Nov 16, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 16, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2630.swalot.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/754cffd4545c0012748e42366fafa986 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 16, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/63d5beb70d786e9aed0fe8ae6e3e463c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 16, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3146.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/bac6d86cee04933a152c50cbaab96ebf for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 17, 2019

@smoors OK to merge?

@akesandgren
Copy link
Copy Markdown
Contributor

@branfosj Does this version of hypothesis depend on attrs >= 19.2 then?

@branfosj
Copy link
Copy Markdown
Member Author

Yes. hypothesis 4.38.2 bumped the required attrs to >=19.2.0 - https://hypothesis.readthedocs.io/en/latest/changes.html#v4-38-2

For PyTorch I believe that I do not need such a recent hypothesis, so there is an option to go with 4.37.0 instead and multi_deps it.

@akesandgren
Copy link
Copy Markdown
Contributor

Ok, then let's go with this one ....

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @branfosj!

1 similar comment
@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @branfosj!

@akesandgren akesandgren dismissed smoors’s stale review November 17, 2019 13:21

can't do multi-deps here due to needing an updated "attrs" version.,

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @branfosj!

@akesandgren akesandgren merged commit 70eb825 into easybuilders:develop Nov 17, 2019
@branfosj branfosj deleted the 20191116173309_new_pr_hypothesis4442 branch November 17, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants