Skip to content

add missing extensions required by Sphinx & pytest to Python 3.7.{2,4}#9329

Merged
boegel merged 6 commits intoeasybuilders:developfrom
Flamefire:20191119134050_new_pr_Python372
Nov 21, 2019
Merged

add missing extensions required by Sphinx & pytest to Python 3.7.{2,4}#9329
boegel merged 6 commits intoeasybuilders:developfrom
Flamefire:20191119134050_new_pr_Python372

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Nov 19, 2019

(created using eb --new-pr)

@Flamefire Flamefire mentioned this pull request Nov 19, 2019
Closed
migueldiascosta
migueldiascosta requested changes Nov 19, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/p/Python/Python-3.7.2-GCCcore-8.2.0.eb
@migueldiascosta migueldiascosta added this to the next release (4.1.0) milestone Nov 19, 2019
@easybuilders easybuilders deleted a comment from boegelbot Nov 19, 2019
@boegel boegel changed the title Add missing dependencies to Python 3.7.{2,4} add missing extensions required by Sphinx & pytest to Python 3.7.{2,4} Nov 19, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 19, 2019

@Flamefire Looks OK for Python 3.7.4 (pip check passes), but not for Python 3.7.2:

== 2019-11-19 22:35:52,794 build_log.py:164 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:124 in __init__): Sanity check failed: extensions sanity check failed for 5 extensions: sphinxcontrib-applehelp, sphinxcontrib-devhelp, sphinxcontrib-htmlhelp, sphinxcontrib-qthelp, sphinxcontrib-serializinghtml
failing sanity check for 'sphinxcontrib-applehelp' extension: command "python -c "import sphinxcontrib.applehelp"" failed; output:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinxcontrib/applehelp/__init__.py", line 24, in <module>
    from sphinx.util import SkipProgressMessage, progress_message
ImportError: cannot import name 'SkipProgressMessage' from 'sphinx.util' (/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinx/util/__init__.py),
failing sanity check for 'sphinxcontrib-devhelp' extension: command "python -c "import sphinxcontrib.devhelp"" failed; output:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinxcontrib/devhelp/__init__.py", line 25, in <module>
    from sphinx.util.nodes import NodeMatcher
ImportError: cannot import name 'NodeMatcher' from 'sphinx.util.nodes' (/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinx/util/nodes.py),
failing sanity check for 'sphinxcontrib-htmlhelp' extension: command "python -c "import sphinxcontrib.htmlhelp"" failed; output:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinxcontrib/htmlhelp/__init__.py", line 28, in <module>
    from sphinx.util import progress_message
ImportError: cannot import name 'progress_message' from 'sphinx.util' (/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinx/util/__init__.py),
failing sanity check for 'sphinxcontrib-qthelp' extension: command "python -c "import sphinxcontrib.qthelp"" failed; output:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinxcontrib/qthelp/__init__.py", line 26, in <module>
    from sphinx.util.nodes import NodeMatcher
ImportError: cannot import name 'NodeMatcher' from 'sphinx.util.nodes' (/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinx/util/nodes.py),
failing sanity check for 'sphinxcontrib-serializinghtml' extension: command "python -c "import sphinxcontrib.serializinghtml"" failed; output:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinxcontrib/serializinghtml/__init__.py", line 16, in <module>
    from sphinx.deprecation import RemovedInSphinx40Warning, deprecated_alias
ImportError: cannot import name 'deprecated_alias' from 'sphinx.deprecation' (/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/site-packages/sphinx/deprecation.py),  (at easybuild/framework/easyblock.py:2592 in _sanity_check_step)

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Nov 20, 2019

Ok so am I seeing this correctly?:

  • sphinx depends on sphinxcontrib-applehelp
  • sphinxcontrib-applehelp uses sphinx

On the actual error: Seems 3.7.2 uses Sphinx 1.x which only requires sphinxcontrib-websupport

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Nov 21, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, AMD EPYC 7601 32-Core Processor, Python 2.7.5
See https://gist.github.com/722f04dfef85eb3a1d09dd461bbf5f0c for a full test report.

migueldiascosta
migueldiascosta approved these changes Nov 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

boegel
boegel approved these changes Nov 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test report coming up...

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 21, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/b679d0d2522877256181ccdf3ed87783 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 21, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3124.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/5dab9b97ecf0c06c85e44339dec9d42e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 21, 2019

Going in, thanks @Flamefire!

@boegel boegel merged commit c9b554e into easybuilders:develop Nov 21, 2019
@Flamefire Flamefire deleted the 20191119134050_new_pr_Python372 branch November 21, 2019 10:54
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Nov 21, 2019

Test report by @Flamefire
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
taurusi6296.taurus.hrsk.tu-dresden.de - Linux RHEL 7.4, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/e856aef04470397ade57f7307158910c for a full test report.

@boegel boegel mentioned this pull request Nov 24, 2019
Merged
@boegel boegel mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @boegel @migueldiascosta