Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
|
@hajgato: nice job! I was looking into this too, but didn't get to making a PR for it yet, you beat me to it. ;-) The For pull requests that add a new toolchain, we usually ask to include an easyconfig file that uses that toolchain, to make sure that the toolchain itself is tested. I'll issue a PR for the definition of the So, I'd like to hear from the others whether they can agree with the definition of this
@stdweird/@JensTimmerman, @georgets/@tloizou, @fgeorgatos, @pescobar, @pforai/@azet, @georg-rath/@ebirn, @hpcleuven/@gjbex, @geimer, @arungolfy: We discussed this already and there didn't seem to be any remarks w.r.t. versions/components, but getting a +1 on this by most of you would be nice... |
There was a problem hiding this comment.
you should add numactl as a dependency here, since it enhances hwloc:
dependencies = [('numactl', '2.0.9')]
configopts = "--enable-libnuma=$EBROOTLIBNUMA"|
Framework support for this in contributed in easybuilders/easybuild-framework#956 by @gjbex |
|
boegel: You mean FFTW 3.3.4 and not 3.5.0, right? |
|
@hajgato: yes, sorry, copy-paste error, I corrected it in my earlier comment |
…cc, similarly to OpenBLAS, as it builds with gcc. HPL-foss-201b added
…cc, similarly to OpenBLAS, as it builds with gcc. HPL-foss-201b added
|
s/foss/libre/g |
|
+1
|
|
+1 |
1 similar comment
|
+1 |
|
W.r.t. foss vs libre: we've been over this briefly during the hackathon. We can discuss this endlessly, but in the end it's just a toolchain name that nobody will know what it stands for... Especially for the open-source common toolchain being contributed here, the name is even less important (since if you have Intel compilers available, you'll typically be installed software with that instead). I consider So, let's just stick to In the end, we will hopefully end up with using a hierarchical module naming scheme, which can hide toolchains from users all together (keep an eye on the upcoming EasyBuild v1.14 w.r.t. that, we made excellent progress on that during the last hackathon). |
There was a problem hiding this comment.
@hajgato: ok, this is my fault. The correct value being passed should of course be $EBROOTNUMACTL (it's always $EBROOTX with X being the uppercase software name). Then you can also drop the #numactl comment
There was a problem hiding this comment.
@hajgato: there's still a typo in here, it should be:
configopts = "--enable-libnuma=$EBROOTNUMACTL"I'll test this out ASAP, and also tackle the intel toolchain.
There was a problem hiding this comment.
(note: typo fixed in previous comment)
|
Test report by @boegel |
|
Tested this on top of easybuilders/easybuild-framework#956, so good to go as soon as that one is merged in. |
|
Jenkins: test this please |
1 similar comment
|
Jenkins: test this please |
|
looking good to me. |
This is the VSC foss 2014b toolchain. The foss toolchain should be added to easybuild in order to test these configs.