Skip to content

fix linker errors when linking with libths.a for MetaBAT 2.12.1#9379

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:fix_MetaBAT
Nov 27, 2019
Merged

fix linker errors when linking with libths.a for MetaBAT 2.12.1#9379
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:fix_MetaBAT

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 26, 2019

fixes #8933

@boegel boegel added the bug fix label Nov 26, 2019
@boegel boegel added this to the 4.1.0 milestone Nov 26, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/a8fd47148ca898406d3fd7aa37147fb5 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2419.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/6dd0d5651833a3b5b84522965a34cd77 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3158.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/b25bdc39518d194ef56d96936e2c84a7 for a full test report.

@boegel boegel mentioned this pull request Nov 26, 2019
Closed
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 26, 2019

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.7.1908, Intel Xeon Processor (Skylake, IBRS), Python 2.7.5
See https://gist.github.com/1c378e8cc4def5853f85f9d2a216903e for a full test report.

verdurin
verdurin approved these changes Nov 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 26, 2019

(close + re-open to re-trigger Travis test, seems like notification didn't make it back to GitHub)

@boegel boegel closed this Nov 26, 2019
@boegel boegel reopened this Nov 26, 2019
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 27, 2019

Going in, thanks @boegel!

@verdurin verdurin merged commit 291b601 into easybuilders:develop Nov 27, 2019
@boegel boegel deleted the fix_MetaBAT branch November 27, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

MetaBAT installation failure because libhts.a required -lcurl (which requires -lssl)

2 participants

@boegel @verdurin