Skip to content

{chem}[iccifort/2019.5.281] NCIPLOT v4.0-20190718#9419

Merged
migueldiascosta merged 3 commits intoeasybuilders:developfrom
smoors:20191202133730_new_pr_NCIPLOT4020190718
Dec 30, 2019
Merged

{chem}[iccifort/2019.5.281] NCIPLOT v4.0-20190718#9419
migueldiascosta merged 3 commits intoeasybuilders:developfrom
smoors:20191202133730_new_pr_NCIPLOT4020190718

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Dec 2, 2019

(created using eb --new-pr)

@smoors smoors added the new label Dec 2, 2019
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Dec 2, 2019

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node376.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/fe6b9b626ae89c45b1d92d09572ac1c6 for a full test report.

}

# site-specific: set OMP_NUM_THREADS equal to number of available cores
modluafooter = 'if os.getenv("PBS_NUM_PPN") ~= nil then pushenv("OMP_NUM_THREADS", os.getenv("PBS_NUM_PPN")) end'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part doesn't really belong here. It's the responsibility of the user to set OMP_NUM_THREADS.
(And the responsibility of the site documentation to tell them how and when :-)

@smoors smoors dismissed akesandgren’s stale review December 5, 2019 16:10

changed addressed

@migueldiascosta
Copy link
Copy Markdown
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/f041c95b7016eb3a971f894084776a0e for a full test report.

Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta migueldiascosta added this to the next release (4.1.1) milestone Dec 30, 2019
@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @smoors!

@migueldiascosta migueldiascosta merged commit 5ff5aa2 into easybuilders:develop Dec 30, 2019
@smoors smoors deleted the 20191202133730_new_pr_NCIPLOT4020190718 branch January 15, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants