Skip to content

fix build of recent Bazel versions on Power9 + stick to Java/1.8 as dependency#9455

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20191206163049_new_pr_Bazel0261
Dec 24, 2019
Merged

fix build of recent Bazel versions on Power9 + stick to Java/1.8 as dependency#9455
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20191206163049_new_pr_Bazel0261

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Dec 6, 2019 •
edited
Loading

Fixes #9450

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Dec 7, 2019

Requires easybuilders/easybuild-easyblocks#1875 on Power9

@Flamefire Flamefire changed the title Stay with JDK8 (Java 1.8) as stated by Bazel docus Fix build of Bazel on Power9 Dec 7, 2019
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Dec 7, 2019

Test report by @Flamefire
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
taurusml8 - Linux RHEL 7.6, 8335-GTX, Python 2.7.5
See https://gist.github.com/699562329a8cc64f166bcbbf944e9c77 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Dec 7, 2019

Test report by @Flamefire
SUCCESS
Build succeeded for 6 out of 6 (4 easyconfigs in this PR)
taurusi1242.taurus.hrsk.tu-dresden.de - Linux RHEL 7.4, Intel(R) Xeon(R) CPU E5-2690 0 @ 2.90GHz, Python 2.7.5
See https://gist.github.com/a35575e7a590674c0f2eee2fa3d2da87 for a full test report.

@boegel boegel added the bug fix label Dec 8, 2019
@boegel boegel added this to the release after 4.1.0 (4.1.1?) milestone Dec 8, 2019
@boegel boegel mentioned this pull request Dec 10, 2019
Closed
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2019

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node3131.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/fa45ffdbdc6fe1184777fd08f0619ad8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2019

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2409.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/3fb1fe28957c7c24fad1bb0c23ab1f95 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2019

We usually avoid changing dependency versions in existing easyconfigs, but in this case I think it's justified (as a bug fix), and in addition Bazel is only used as a build dependency for TensorFlow.
The passing easyconfigs test suite confirms that no version conflicts on Java have been introduced by this change.

@branfosj Are you up for submitting a test report for this, taking into account that you'll need to use the updated Bazel easyblock from easybuilders/easybuild-easyblocks#1875?

@boegel boegel changed the title Fix build of Bazel on Power9 fix build of Bazel on Power9 + stick to Java/1.8 as dependency Dec 10, 2019
@boegel boegel changed the title fix build of Bazel on Power9 + stick to Java/1.8 as dependency fix build of recent Bazel versions on Power9 + stick to Java/1.8 as dependency Dec 10, 2019
@boegel boegel mentioned this pull request Dec 10, 2019
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2019

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/269ee07dcd557ef98067e6ab1765615e for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Dec 12, 2019

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
bear-pg0305u05a.bear.cluster - Linux RHEL 7.6, 8335-GTX, Python 2.7.5
See https://gist.github.com/9faa0934e68506990b343d33dc729c33 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Dec 12, 2019

Looks good to me!

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Dec 12, 2019

Great! If you don't mind I'll update easybuilders/easybuild-easyblocks#1875 to always use system JDK (only change for x86)

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 24, 2019

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node3128.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/fe82c8607b4e47f684ce1d8c6070d181 for a full test report.

boegel
boegel approved these changes Dec 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 24, 2019

Going in, thanks @Flamefire!

@boegel boegel merged commit c80ef9b into easybuilders:develop Dec 24, 2019
@Flamefire Flamefire deleted the 20191206163049_new_pr_Bazel0261 branch December 24, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

Bazel not installable on Power9 - Missing Java 11

3 participants

@Flamefire @boegel @branfosj