Skip to content

make installing independent of build folder in pybind11 easyconfig#9738

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20200120135211_new_pr_pybind11224
Apr 1, 2020
Merged

make installing independent of build folder in pybind11 easyconfig#9738
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20200120135211_new_pr_pybind11224

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jan 20, 2020

(created using eb --new-pr)

@Flamefire Flamefire changed the title [PyBind11] Make installating independent of build folder [PyBind11] Make installing independent of build folder Feb 14, 2020
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 3, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/4252efd5483090624139d18621525d62 for a full test report.

@migueldiascosta migueldiascosta added this to the 4.x milestone Mar 3, 2020
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 16, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
taurusi6258.taurus.hrsk.tu-dresden.de - Linux RHEL 7.7, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/cfef295b32bbe3148b0acf7790e0e127 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 31, 2020

@boegel This is required for the CMake changes in easybuilders/easybuild-easyblocks#1933

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Apr 1, 2020

@boegel This would benefit of easybuilders/easybuild-framework#3160 :)

@Flamefire Flamefire mentioned this pull request Apr 1, 2020
Merged
@boegel boegel modified the milestones: 4.x, next release (4.2.0) Apr 1, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 1, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3114.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/41dfe8daf1c39592cff1f569942e0567 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 1, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2711.swalot.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fe02c47c9c80e33f14f7292b0d07d5b8 for a full test report.

boegel
boegel approved these changes Apr 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title [PyBind11] Make installing independent of build folder make installing independent of build folder in pybind11 easyconfig Apr 1, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 1, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit f57e842 into easybuilders:develop Apr 1, 2020
@Flamefire Flamefire deleted the 20200120135211_new_pr_pybind11224 branch April 1, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @migueldiascosta @boegel