Skip to content

{bio}[foss/2018b] split-seq v20190717 w/ Python 3.6.6#9749

Merged
migueldiascosta merged 4 commits intoeasybuilders:developfrom
lexming:20200121105241_new_pr_split-seq20191107
Mar 4, 2020
Merged

{bio}[foss/2018b] split-seq v20190717 w/ Python 3.6.6#9749
migueldiascosta merged 4 commits intoeasybuilders:developfrom
lexming:20200121105241_new_pr_split-seq20191107

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jan 21, 2020

(created using eb --new-pr)

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jan 21, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
login2.cerberus.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz, Python 2.7.5
See https://gist.github.com/da7a8a0bec2fb8e17916b0cabfab40b5 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Feb 13, 2020
migueldiascosta
migueldiascosta requested changes Mar 3, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/s/split-seq/split-seq-20191107-add_pkl_barcodes.patch Outdated
@@ -0,0 +1,17 @@
--- MANIFEST.in 2019-11-13 15:09:45.174322190 +0100
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add description and author

Copy link
Copy Markdown
Contributor Author

@lexming lexming Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made that patch to push it upstream, but in hindsight it is overkill for this easyconfig. That fix can be done with a simple cp command in postinstallcmds. So I updated the easyconfig to not need any patch files.

@migueldiascosta migueldiascosta added this to the 4.x milestone Mar 3, 2020
migueldiascosta
migueldiascosta reviewed Mar 3, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/s/split-seq/split-seq-20191107-foss-2018b-Python-3.6.6.eb Outdated
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 3, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/7af48276354e955621710de4aa86f2d1 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Mar 3, 2020

@migueldiascosta I switched the sources of this easyconfig to the main fork of split-seq, as it is actively developed. I'll submit new tests.

@lexming lexming changed the title {bio}[foss/2018b] split-seq v20191107 w/ Python 3.6.6 {bio}[foss/2018b] split-seq v20190717 w/ Python 3.6.6 Mar 3, 2020
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Mar 3, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
login2.cerberus.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c2873ce1addbe9f8d2d039e48fe5e887 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 4, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/8fcbdab907eb46ea31d4a7c247b7d2a8 for a full test report.

migueldiascosta
migueldiascosta approved these changes Mar 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 4, 2020

Going in, thanks @lexming!

@migueldiascosta migueldiascosta merged commit 09b23e8 into easybuilders:develop Mar 4, 2020
@lexming lexming deleted the 20200121105241_new_pr_split-seq20191107 branch March 4, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lexming @migueldiascosta