Skip to content

add Lua as a dependency to gnuplot#9773

Merged
boegel merged 7 commits intoeasybuilders:developfrom
branfosj:20200123170816_new_pr_gnuplot526
Mar 3, 2020
Merged

add Lua as a dependency to gnuplot#9773
boegel merged 7 commits intoeasybuilders:developfrom
branfosj:20200123170816_new_pr_gnuplot526

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 23, 2020 •
edited
Loading

(created using eb --new-pr)

One of our systems does not have Lua installed and we get a missing Lua.h when building gnuplot. This covers all gnuplot versions in 2018a or later toolchains. I'm not sure how much further than that I should go back.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 24, 2020

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
bber0501u03a.bb2.cluster - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/74015e241097a3280db241b8ca93fc12 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 24, 2020

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz, Python 2.7.5
See https://gist.github.com/713696109ef39ee6ef63edc869295574 for a full test report.

@zao zao mentioned this pull request Mar 1, 2020
Merged
boegel
boegel requested changes Mar 2, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/g/gnuplot/gnuplot-5.2.5-foss-2018b.eb Outdated
@boegel boegel added the bug fix label Mar 2, 2020
@boegel boegel added this to the next release (4.1.2?) milestone Mar 2, 2020
@easybuilders easybuilders deleted a comment from boegelbot Mar 2, 2020
boegel
boegel previously approved these changes Mar 2, 2020
View reviewed changes
@boegel boegel mentioned this pull request Mar 2, 2020
Closed
boegel
boegel approved these changes Mar 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 3, 2020

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/d08b44aa7c1514a3c612c7da2e48b3a9 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 3, 2020

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node2401.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/9724cd83cadb1bb72ff4c30a930fb90e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 3, 2020

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node3102.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/36e8ac1409fdaf5e23a2fb28d143b189 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 3, 2020

Going in, thanks @branfosj!

@boegel boegel merged commit 200bfed into easybuilders:develop Mar 3, 2020
@branfosj branfosj deleted the 20200123170816_new_pr_gnuplot526 branch March 3, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @boegel