add patches to fix installation of R 3.6.2 on POWER#9830
add patches to fix installation of R 3.6.2 on POWER#9830lexming merged 3 commits intoeasybuilders:developfrom
Conversation
|
@Flamefire Does this depend on other PRs, or did you accidentally mess up the test environment? |
|
Depends. It fixes compilation of R as-is. The extensions aren't fixed yet. E.g. liquidSVM needs to be removed: https://github.com/easybuilders/easybuild-easyconfigs/pull/9544/files#r365531097 I updated the initial description with the dependencies for Power9 |
8cd9d58 to
4d256d9
Compare
|
@boegel Regarding liquidSVM: It seems it won't use the std flag for cuda which would solve the issue (tried patching it manually) So either we patch their https://github.com/liquidSVM/liquidSVM/blob/da19280562f443ab2b1fca898862f76c4ebc0bbd/bindings/R/liquidSVM/configure somehow or remove liquidSVM indeed, but that would be hard to argue for (as it works for most). I'm also concerned about it "Using target: generic" (see logs) but that might be R... |
c551157 to
621c946
Compare
|
Test report by @Flamefire |
|
@Flamefire Would be good to see a test from another POWER9 machine if possible. |
|
Working on a x86 report. @edmondac can probably provide one from another Power9 |
|
Test report by @Flamefire |
|
Test reports running now... |
|
Test report by @bear-rsg |
|
Test report by @bear-rsg |
|
@verdurin I've added a test report for x86_64 and another for ppc64le |
|
@migueldiascosta Can this be merged? Pending the other PRs for fully building, but it does improve it and does not break anything. It just errors at different stages on Power without the other PRs. (Of course would be great to have them merged too, but some are not fully ready yet) |
|
Test report by @migueldiascosta |
|
@migueldiascosta Failed to remove the folder? The error is way to generic. Better: easybuilders/easybuild-framework#3228 |
|
Test report by @zao |
621c946 to
9e30ba7
Compare
9e30ba7 to
f22e33f
Compare
|
Rebased to develop, running tests on x86 and Power9 without easybuilders/easybuild-easyblocks#1949 now |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
x86 succeeded and Power failed (as expected) Running tests with easybuilders/easybuild-easyblocks#1949 now |
|
I've also set off x86 and Power tests of this PR using easybuilders/easybuild-easyblocks#1949 |
|
Test report by @branfosj |
|
Test report by @branfosj |
|
Test report by @branfosj |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Test report by @lexming |
…asyconfigs into 20200205084938_new_pr_R362
|
Test report by @lexming |
lexming
left a comment
There was a problem hiding this comment.
Synced to develop and everything built fine.
LGTM
|
Going in, thanks @Flamefire ! |
|
Great! Now only easybuilders/easybuild-easyblocks#1949 is missing for Power support of R. Added the change I was talking about there so should be ready to merge after CI ran through. |
(created using
eb --new-pr)For build in Power9 requires: