Skip to content

{bio}[intel/2019a] Red v2015-05-22#9856

Merged
boegel merged 2 commits intoeasybuilders:developfrom
bjmoran:20200211175736_new_pr_Red20150522
Feb 18, 2020
Merged

{bio}[intel/2019a] Red v2015-05-22#9856
boegel merged 2 commits intoeasybuilders:developfrom
bjmoran:20200211175736_new_pr_Red20150522

Conversation

@bjmoran
Copy link
Copy Markdown
Contributor

@bjmoran bjmoran commented Feb 11, 2020

(created using eb --new-pr)

@boegel boegel added the new label Feb 11, 2020
@boegel boegel added this to the 4.x milestone Feb 11, 2020
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjmoran Thank you very much for your contribution!

I tried this myself, and it works, but it doesn't exactly compile as intended:

 /usr/bin/g++ -O3 -g -fmessage-length=0 -Wall  -c RepeatsDetector.cpp -o ../bin/Red.o

Problems:

  • it uses the system C++ compiler /usr/bin/g++ rather than the one provided by the toolchain
  • it uses -O3 rather than the compiler options specified in $CXXFLAGS

It looks like you can fix this byy adding this to your easyconfig file:

buildopts = 'CXX="$CXX" CXXFLAGS="$CXXFLAGS -fmessage-length=0"

I'm not sure what the -fmessage-length=0 that is used by default does, so it may be best to keep using that.

In addition, there's no need to use a full toolchain like intel here, since Red doesn't require MPI or BLAS/LAPACK, so you could downgrade the toolchain to iccifort?

@bjmoran
Copy link
Copy Markdown
Contributor Author

bjmoran commented Feb 11, 2020

@boegel I've added a commit with your requested changes. Thanks for your review!

@bjmoran bjmoran requested a review from boegel February 18, 2020 13:08
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/c2d8387b8eeb65291eb7363de4089279 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar05.gastly.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 2.7.5
See https://gist.github.com/e90aa7c69a72eb7f5ddb7aac2f3fcbfd for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2417.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ec8604a270cafbedf62c28285dd9a094 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.1.2?) Feb 18, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2020

Going in, thanks @bjmoran!

@boegel boegel merged commit 8becc19 into easybuilders:develop Feb 18, 2020
@bjmoran bjmoran deleted the 20200211175736_new_pr_Red20150522 branch February 19, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants