Skip to content

{vis}[GCCcore/8.3.0] XCrySDen v1.6.2, Togl v2.0, bwidget v1.9.14#9868

Merged
boegel merged 3 commits intoeasybuilders:developfrom
migueldiascosta:20200213110039_new_pr_XCrySDen162
Feb 24, 2020
Merged

{vis}[GCCcore/8.3.0] XCrySDen v1.6.2, Togl v2.0, bwidget v1.9.14#9868
boegel merged 3 commits intoeasybuilders:developfrom
migueldiascosta:20200213110039_new_pr_XCrySDen162

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Feb 13, 2020 •
edited
Loading

(created using eb --new-pr)

requires easybuilders/easybuild-easyblocks#1959

@migueldiascosta
adding easyconfigs: XCrySDen-1.6.2-foss-2019b.eb, XCrySDen-1.6.2-inte…
71b3646 
…l-2019b.eb, Togl-2.0-GCCcore-8.3.0.eb, LibUUID-1.0.3-GCCcore-8.3.0.eb, bwidget-1.9.14-GCCcore-8.3.0.eb and patches: XCrySDen-1.6.2_no-bwidget.patch, Togl-2.0_configure.patch, Togl-2.0_decl.patch
@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Feb 13, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/8e866375b380f48ae3650c2fae848343 for a full test report.

@boegel boegel added this to the 4.x milestone Feb 23, 2020
@boegel boegel changed the title {vis}[GCCcore/8.3.0] XCrySDen v1.6.2, Togl v2.0, LibUUID v1.0.3, ... {vis}[GCCcore/8.3.0] XCrySDen v1.6.2, Togl v2.0, LibUUID v1.0.3, bwidget v1.9.14 Feb 23, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 23, 2020

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node3102.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/7c0b788480d366090823751532bd2989 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 23, 2020

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node2401.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/cf0f0d68e4a4c8514be6f49fb11de21a for a full test report.

boegel
boegel requested changes Feb 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migueldiascosta The LibUUID easyconfig is not required (and it should actually be avoided, see #6963).

Comment thread easybuild/easyconfigs/b/bwidget/bwidget-1.9.14-GCCcore-8.3.0.eb
Comment thread easybuild/easyconfigs/t/Togl/Togl-2.0_configure.patch Outdated
@@ -0,0 +1,42 @@
* remove check for tclInt.h and tkInt.h in source folder, not necessary
author: Miguel Dias Costa (National University of Singapore0
Copy link
Copy Markdown
Member

@boegel boegel Feb 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: 0 -> )

Comment thread easybuild/easyconfigs/x/XCrySDen/XCrySDen-1.6.2_no-bwidget.patch
@@ -0,0 +1,11 @@
--- Makefile.orig 2020-01-16 18:58:30.499898000 +0800
Copy link
Copy Markdown
Member

@boegel boegel Feb 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add missing description + authorship

@boegel boegel modified the milestones: 4.x, next release (4.1.2?) Feb 23, 2020
@migueldiascosta migueldiascosta changed the title {vis}[GCCcore/8.3.0] XCrySDen v1.6.2, Togl v2.0, LibUUID v1.0.3, bwidget v1.9.14 {vis}[GCCcore/8.3.0] XCrySDen v1.6.2, Togl v2.0, bwidget v1.9.14 Feb 23, 2020
@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Feb 23, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/277d8d8677f377b32c1daa231d753b59 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node3104.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/bb354105a8794b818f86ec7dedf10505 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2401.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/893357a98f294f549bc43b18b68776f1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2020

Going in, thanks @migueldiascosta!

@boegel boegel merged commit 95775a4 into easybuilders:develop Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new update

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@migueldiascosta @boegel