Skip to content

use custom easyblock for installing CMake in easyconfig for CMake 3.15.3#9871

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20200214125528_new_pr_CMake3153
Feb 18, 2020
Merged

use custom easyblock for installing CMake in easyconfig for CMake 3.15.3#9871
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20200214125528_new_pr_CMake3153

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
taurusa3 - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz, Python 2.7.5
See https://gist.github.com/91227a7fe75496e071e514ccd0a97643 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 16, 2020

(close/re-open now easybuilders/easybuild-easyblocks#1936 is merged)

@boegel boegel closed this Feb 16, 2020
@boegel boegel reopened this Feb 16, 2020
@easybuilders easybuilders deleted a comment from boegelbot Feb 16, 2020
@boegel boegel added the change label Feb 16, 2020
@boegel boegel added this to the next release (4.1.2?) milestone Feb 16, 2020
@boegel boegel changed the title Use new CMake EB use custom easyblock for installing CMake in easyconfig for CMake 3.15.3 Feb 16, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/20eddb3797d741269e29943433b0a5be for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3102.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/0a93d78560ed4f20aaae276cfca32aec for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit 5b00d34 into easybuilders:develop Feb 18, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2403.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/7b9290480732677439aebb67c389e0b1 for a full test report.

@Flamefire Flamefire deleted the 20200214125528_new_pr_CMake3153 branch February 18, 2020 13:58
@Flamefire
Copy link
Copy Markdown
Contributor Author

I'll convert the other CMake ECs soon to have this uniform (besides that this approach is superior as the correct modules will be used even for the older ECs that are written differently and there is less code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants