Skip to content

fix source URLs for rgeos after source tarball was moved to CRAN archive#9954

Merged
boegel merged 2 commits intoeasybuilders:developfrom
arielzn:20200302161625_new_pr_rgeos051
Mar 3, 2020
Merged

fix source URLs for rgeos after source tarball was moved to CRAN archive#9954
boegel merged 2 commits intoeasybuilders:developfrom
arielzn:20200302161625_new_pr_rgeos051

Conversation

@arielzn
Copy link
Copy Markdown
Contributor

@arielzn arielzn commented Mar 2, 2020

(created using eb --new-pr)

@boegel boegel changed the title source tarball moved to cran Archive fix source URLs for rgeos after source tarball was moved to CRAN archive Mar 2, 2020
toolchain = {'name': 'foss', 'version': '2019a'}

source_urls = ['https://cran.r-project.org/src/contrib/']
source_urls = ['https://cran.r-project.org/src/contrib/Archive/rgeos']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielzn We should keep both URLs, to avoid running into this issue again with future versions of rgeos?

Also, please apply the same fix to the other rgeos easyconfigs (especially since it's trivial to verify the fix via eb --fetch)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i'll add for all.

I think once there's a new version, any archived stays forever in /contrib/Archive.
but for consistency probably makes more sense to have all R packages with both urls.

@boegel boegel added the bug fix label Mar 2, 2020
@boegel boegel added this to the next release (4.1.2?) milestone Mar 2, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 3, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3130.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/341fb52be91cc76c06c31d1d107ac9b3 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 3, 2020

Going in, thanks @arielzn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants