Skip to content

{bio}[GCCcore/8.3.0] PRSice v2.2.12#9988

Merged
boegel merged 6 commits intoeasybuilders:developfrom
sassy-crick:20200305103014_new_pr_PRSice2212
Mar 8, 2020
Merged

{bio}[GCCcore/8.3.0] PRSice v2.2.12#9988
boegel merged 6 commits intoeasybuilders:developfrom
sassy-crick:20200305103014_new_pr_PRSice2212

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Mar 5, 2020

(created using eb --new-pr)

@easybuilders easybuilders deleted a comment from boegelbot Mar 7, 2020
boegel
boegel requested changes Mar 7, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/p/PRSice/PRSice-2.2.12-GCCcore-8.3.0.eb Outdated

sanity_check_paths = {
'files': ['bin/PRSice'],
'dirs': ['bin'],
Copy link
Copy Markdown
Member

@boegel boegel Mar 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sassy-crick Also checking for a non-empty bin directory when you're already checking for bin/PRSice is a bit silly, so let's trim this down to:

sanity_check_paths = {
    'files': ['bin/PRSice'],
    'dirs': [],
}

Comment thread easybuild/easyconfigs/p/PRSice/PRSice-2.2.12-GCCcore-8.3.0.eb
@boegel boegel added the new label Mar 7, 2020
@boegel boegel added this to the 4.x milestone Mar 7, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3120.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/4314b23478a6922d46c4b193dfd238d4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/91e2c97656e13c6f49c33a5026404f5e for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.1.2?) Mar 8, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2408.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d4991b666112f0e09f83d1b4e87b3a8a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2020

Going in, thanks @sassy-crick!

@boegel boegel merged commit d8effca into easybuilders:develop Mar 8, 2020
@boegel boegel changed the title PRSice EB file created {bio}[GCCcore/8.3.0] PRSice v2.2.12 Mar 8, 2020
@sassy-crick sassy-crick deleted the 20200305103014_new_pr_PRSice2212 branch March 8, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sassy-crick @boegel