Skip to content

{bio}[foss/2019b] RAxML-NG v0.9.0#9990

Merged
migueldiascosta merged 15 commits intoeasybuilders:developfrom
albertogfernan:20200305104642_new_pr_RAxML-NG090
Mar 27, 2020
Merged

{bio}[foss/2019b] RAxML-NG v0.9.0#9990
migueldiascosta merged 15 commits intoeasybuilders:developfrom
albertogfernan:20200305104642_new_pr_RAxML-NG090

Conversation

@albertogfernan
Copy link
Copy Markdown
Contributor

@albertogfernan albertogfernan commented Mar 5, 2020

(created using eb --new-pr)

@migueldiascosta migueldiascosta added this to the 4.x milestone Mar 6, 2020
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 6, 2020

Test report by @migueldiascosta
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/8666d0a980581f5cb413003b164c42d5 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Mar 6, 2020
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 6, 2020

thanks @albertogfernan!

The test failure is due a failing checksum, which is likey due to the use of git_config, see note in https://easybuild.readthedocs.io/en/latest/Writing_easyconfig_files.html#common-easyconfig-param-sources-git-config. I suppose using the release packages is not an option?

Related to easybuilders/easybuild-framework#2727 and easybuilders/easybuild-framework#2727

migueldiascosta
migueldiascosta requested changes Mar 6, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-foss-2019b.eb Outdated
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-foss-2019b.eb Outdated
boegel
boegel previously requested changes Mar 6, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-foss-2019b.eb Outdated
@albertogfernan albertogfernan mentioned this pull request Mar 6, 2020
Closed
migueldiascosta
migueldiascosta requested changes Mar 24, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
migueldiascosta
migueldiascosta previously requested changes Mar 25, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
migueldiascosta
migueldiascosta reviewed Mar 26, 2020
View reviewed changes
Comment thread easybuild/easyconfigs/r/RAxML-NG/RAxML-NG-0.9.0-gompi-2019b.eb Outdated
@migueldiascosta migueldiascosta dismissed stale reviews from boegel and themself March 26, 2020 14:27

changes addressed

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 26, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, AMD EPYC 7601 32-Core Processor, Python 2.7.5
See https://gist.github.com/1fa38d85e0ff03fce4cfb975d33e4e04 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 27, 2020

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/148de0ff0edc5fc75b2e5657240411b5 for a full test report.

migueldiascosta
migueldiascosta approved these changes Mar 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Mar 27, 2020

Going in, thanks @albertogfernan!

@migueldiascosta migueldiascosta merged commit efccc5f into easybuilders:develop Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

@boegel boegel Awaiting requested review from boegel

Assignees

No one assigned

Labels

new update

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@albertogfernan @migueldiascosta @boegel