Skip to content

{bio}[GCC/8.2.0-2.31.1,GCC/8.3.0] Jellyfish v2.3.0: fix checksums#9997

Merged
boegel merged 1 commit intoeasybuilders:developfrom
lexming:20200306105830_new_pr_Jellyfish230
Mar 6, 2020
Merged

{bio}[GCC/8.2.0-2.31.1,GCC/8.3.0] Jellyfish v2.3.0: fix checksums#9997
boegel merged 1 commit intoeasybuilders:developfrom
lexming:20200306105830_new_pr_Jellyfish230

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Mar 6, 2020 •
edited
Loading

(created using eb --new-pr)
The checksums for the tarballs of Jellyfish v2.3.0 from Github seem to have changed. Apparently, it is possible to add commits to a tag after the release of a package and it gets stealth updated.
https://github.com/gmarcais/Jellyfish/commits/v2.3.0

@lexming lexming changed the title Jellyfish-2.3.0: fix checksum {bio}[GCC/8.2.0-2.31.1,GCC/8.3.0] Jellyfish v2.3.0: fix checksums Mar 6, 2020
@lexming lexming added the bug fix label Mar 6, 2020
@lexming lexming added this to the 4.x milestone Mar 6, 2020
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Mar 6, 2020

Test report by @lexming
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
login2.cerberus.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz, Python 2.7.5
See https://gist.github.com/df818349f572b44839985a163e2fbd37 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2020

Looks like they've moved the tag at some point...

For what it's worth, the diff:

$ diff -ru jellyfish-2.3.0.old jellyfish-2.3.0
Only in jellyfish-2.3.0.old: LICENSE
Only in jellyfish-2.3.0: LICENSE-BSD-3-Clause
Only in jellyfish-2.3.0: LICENSE-GPL-3.0
diff -ru jellyfish-2.3.0.old/Makefile.am jellyfish-2.3.0/Makefile.am
--- jellyfish-2.3.0.old/Makefile.am     2019-08-23 19:10:08.000000000 +0200
+++ jellyfish-2.3.0/Makefile.am 2020-02-05 18:53:57.000000000 +0100
@@ -1,7 +1,7 @@
 ACLOCAL_AMFLAGS = -I m4
 DISTCHECK_CONFIGURE_FLAGS=--enable-swig --enable-all-binding

-EXTRA_DIST = doc/jellyfish.pdf doc/jellyfish.man README LICENSE # jellyfish.spec
+EXTRA_DIST = doc/jellyfish.pdf doc/jellyfish.man README LICENSE-BSD-3-Clause LICENSE-GPL-3.0 # jellyfish.spec
 man1_MANS = doc/jellyfish.man

 pkgconfigdir = $(libdir)/pkgconfig
diff -ru jellyfish-2.3.0.old/Makefile.in jellyfish-2.3.0/Makefile.in
--- jellyfish-2.3.0.old/Makefile.in     2019-08-23 19:10:12.000000000 +0200
+++ jellyfish-2.3.0/Makefile.in 2020-02-05 18:54:23.000000000 +0100
@@ -742,9 +742,9 @@
 top_srcdir = @top_srcdir@
 ACLOCAL_AMFLAGS = -I m4
 DISTCHECK_CONFIGURE_FLAGS = --enable-swig --enable-all-binding
-EXTRA_DIST = doc/jellyfish.pdf doc/jellyfish.man README LICENSE \
-       $(TESTS) swig/python/test_mer_file.py \
-       swig/python/test_hash_counter.py \
+EXTRA_DIST = doc/jellyfish.pdf doc/jellyfish.man README \
+       LICENSE-BSD-3-Clause LICENSE-GPL-3.0 $(TESTS) \
+       swig/python/test_mer_file.py swig/python/test_hash_counter.py \
        swig/python/test_string_mers.py swig/ruby/test_mer_file.rb \
        swig/ruby/test_hash_counter.rb swig/ruby/test_string_mers.rb \
        swig/perl5/t/test_mer_file.t swig/perl5/t/test_hash_counter.t \

boegel
boegel approved these changes Mar 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3152.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/9691f0777b91dccfe65c101488452c97 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/52edac82779952cd7c744c2e6e049a0a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2020

Going in, thanks @lexming!

@boegel boegel merged commit dbf28fb into easybuilders:develop Mar 6, 2020
@boegel boegel modified the milestones: 4.x, next release (4.1.2?) Mar 6, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2640.swalot.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fc77fb1823ef20f9da880eaba92f4f37 for a full test report.

@lexming lexming deleted the 20200306105830_new_pr_Jellyfish230 branch March 6, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lexming @boegel