add support for excluding module path extensions from generated modules#1003
Conversation
|
This should be used by the GCC easyconfig included in easybuilders/easybuild-easyconfigs#1014 |
There was a problem hiding this comment.
before, you had an if to check this. It's guaranteed that this is not needed anymore?
There was a problem hiding this comment.
when there are no $MODULEPATH extensions, modpath_exts should be an empty list, which will basically make everything below a no-op (except for the log message)
There was a problem hiding this comment.
Then you call self.moduleGenerator.use with a empty list? Isn't that gonna get things like ::: in the $MODULEPATH?
There was a problem hiding this comment.
no, since use loops over the provided list a well (see https://github.com/hpcugent/easybuild-framework/blob/master/easybuild/tools/module_generator.py#L185), and '\n'.join([]) returns and empty string
|
Looks good |
|
Going in, thanks for the review @wpoely86! |
add support for excluding module path extensions from generated modules
@wpoely86: please review