Skip to content

fix bug causing --from-pr to crash hard unless --robot is used#1022

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:from_pr_no_robot
Aug 25, 2014
Merged

fix bug causing --from-pr to crash hard unless --robot is used#1022
boegel merged 2 commits intoeasybuilders:developfrom
boegel:from_pr_no_robot

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 25, 2014

No description provided.

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Aug 25, 2014

I don't entirely understand what this fixes? --from-pr has a problem with None?

All changes look OK.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 25, 2014

@wpoely86: I ran into this:

Traceback (most recent call last):
  File "/prefix/lib/python2.6/site-packages/easybuild_framework-1.15.0dev-py2.6.egg/easybuild/main.py", line 484, in <module>
    main()
  File "/prefix/lib/python2.6/site-packages/easybuild_framework-1.15.0dev-py2.6.egg/easybuild/main.py", line 233, in main
    robot_path.insert(0, pr_path)
AttributeError: 'NoneType' object has no attribute 'insert'

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Aug 25, 2014

OK, I understand.

Looks great then :)

boegel added a commit that referenced this pull request Aug 25, 2014
@boegel
Merge pull request #1022 from boegel/from_pr_no_robot
fc2b207 
fix bug causing --from-pr to crash hard unless --robot is used
@boegel boegel merged commit fc2b207 into easybuilders:develop Aug 25, 2014
@boegel boegel deleted the from_pr_no_robot branch August 25, 2014 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @wpoely86