fix HierarchicalMNS for cgoolf and goolfc toolchains + add iompi definition#1049
fix HierarchicalMNS for cgoolf and goolfc toolchains + add iompi definition#1049boegel merged 7 commits intoeasybuilders:v1.15.xfrom
Conversation
…odule_tree fix path_to_top_of_module_tree to consider multiple paths to the top of the module tree
There was a problem hiding this comment.
please come up with a better and more maintnable solution. like a dict/map module constant.
There was a problem hiding this comment.
I don't think that can work... It might for only the name, but we need to determine the version part too, which can't be easily pushed into a dict imho...
There was a problem hiding this comment.
the sanity check if tc_comps[0]['version'] == tc_comps[1]['version'] not, that you'll have to double verify. but the rest could be done without any issue like
MAP = {
['Clang', 'GCC']: "ClangGCC",
...
}
# saniutycheck MAP
set_map = dict([(set(x),(x,v)) for x,v in MAP.items])
if not len(MAP) == len(set_map): raise something
ordered_comp_names, tc_comp_name = set_map[set(comp_names))]
tc_comp_ver='-',join(map(comp_version.get, ordered_comp_names))
# do something to sanity check intel and fix intel version
There was a problem hiding this comment.
and deal with the KeyError 😄
There was a problem hiding this comment.
@stdweird: remark fixed, it's doable after all...
|
Looks good |
There was a problem hiding this comment.
make it a class constant (will make it a lot easier to create local HMNS) (and indicate in comment that the key is sorted)
|
@stdweird: remarks fixed |
There was a problem hiding this comment.
make this a single test? tc_comp_name == 'intel' and comp_versions['icc'] != comp_versions['ifort']?
|
minor remark, otherwsie ready to merge |
fix HierarchicalMNS for cgoolf and goolfc toolchains + add iompi definition
This enables making HierarchicalMNS compatible with the
goolfc,cgoolfandiomkltoolchain (see also easybuilders/easybuild-easyconfigs#1099 w.r.t.iomkl)