fix unit tests broken due to shellshock patch#1051
Merged
boegel merged 4 commits intoeasybuilders:developfrom Oct 2, 2014
Merged
fix unit tests broken due to shellshock patch#1051boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
Member
There was a problem hiding this comment.
maybe add something more on why?
Member
Author
There was a problem hiding this comment.
well, simply because we're testing, in which case we don't want to use the actual module definition (which can't be controlled in the tests)
Member
|
looks fine |
Member
Author
|
@wpoely86: had to add some extra commits since not all tests were green, please check again? |
Member
|
still looking good |
Member
Author
|
Green light be Jenkins, so going in. Thanks @wpoely86! |
boegel
added a commit
that referenced
this pull request
Oct 2, 2014
fix unit tests broken due to shellshock patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wpoely86: please review