refactor main.py, flesh out functions from main function#1059
refactor main.py, flesh out functions from main function#1059boegel merged 16 commits intoeasybuilders:developfrom
Conversation
|
Test PASSed. |
There was a problem hiding this comment.
move to easyconfig.tweak?
There was a problem hiding this comment.
well, this also relates to --from-pr, which has nothing to do with --try-X or tweak.py... But I'll find a better location for this.
There was a problem hiding this comment.
moved to easyconfig.tools, since get_paths_for also lives there
|
a lot of the functions should be moved to modules. an dnew functions imply new unittests imho. |
|
@stdweird: remarks fixed; w.r.t. unit tests: most of |
There was a problem hiding this comment.
remove reference to robot
|
Test PASSed. |
There was a problem hiding this comment.
add import to previous line
|
reread completed |
|
@stdweird: remarks handled, please rererererererererereview |
|
Test FAILed. |
There was a problem hiding this comment.
use
kwargs={}
if try_to_generate:
kwargs["build_specs"]=build_specs
ecs = process_easyconfig(ec_file, **kwargs)There was a problem hiding this comment.
you mean not if try_to_generate, but ok, fixed
|
@stdweird: fixed remark and broken unit test, not sure if you were done rererererererererereviewing? |
|
Test FAILed. |
|
@stdweird: a test is failing that never should've worked, I'll figure it out |
|
fixed totally broken test, which went undetected because of using |
|
Test PASSed. |
refactor main.py, flesh out functions from main function
@stdweird, @wpoely86: please review?
The diff is going to look a bit messy, maybe you want to look at the actual new
main.pyinstead...