Skip to content

fix picking required version if it's available, clean up in tweak.py module#1063

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:fix_pick_version
Oct 17, 2014
Merged

fix picking required version if it's available, clean up in tweak.py module#1063
boegel merged 3 commits intoeasybuilders:developfrom
boegel:fix_pick_version

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 16, 2014

fix for #1062 reported by @ sylmarien

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

Comment thread easybuild/framework/easyconfig/tweak.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add @param in docstring

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@stdweird
Copy link
Copy Markdown
Contributor

minor remarks, looks good otehrwise

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 17, 2014

All good, reviewed, so going in, thanks @stdweird!

boegel added a commit that referenced this pull request Oct 17, 2014
fix picking required version if it's available, clean up in tweak.py module
@boegel boegel merged commit 5e135a6 into easybuilders:develop Oct 17, 2014
@boegel boegel deleted the fix_pick_version branch October 17, 2014 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants