added a check for the http return code + download progress report#1066
Merged
boegel merged 15 commits intoeasybuilders:developfrom Nov 6, 2014
Merged
added a check for the http return code + download progress report#1066boegel merged 15 commits intoeasybuilders:developfrom
boegel merged 15 commits intoeasybuilders:developfrom
Conversation
JensTimmerman
commented
Oct 21, 2014
- Check the http return code before starting a download, urllib.retrieve does not do this by default
- show a download report ' X kb downloaded of XXX total kb (XX% complete) xxx kbps'
* Check the http return code before starting a download, urllib.retrieve does not do this by default
* show a download report ' X kb downloaded of XXX total kb (XX% complete) xxx kbps'
|
Test PASSed. |
Author
|
rereview please. |
|
Test PASSed. |
|
Test PASSed. |
Member
There was a problem hiding this comment.
If would change this to 4_. All 4_ are client errors and there is no point in retrying.
clean up revamped implementation of download_file
|
Test PASSed. |
minor tweaks in download_file function
|
Test FAILed. |
fix log message in remove_file function
|
Test PASSed. |
Member
|
Merging this in, thanks @JensTimmerman! |
boegel
added a commit
that referenced
this pull request
Nov 6, 2014
added a check for the http return code + download progress report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.