deprecate self.moduleGenerator in favor of self.module_generator in EasyBlock#1088
Merged
boegel merged 2 commits intoeasybuilders:developfrom Nov 7, 2014
Merged
deprecate self.moduleGenerator in favor of self.module_generator in EasyBlock#1088boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
|
Test PASSed. |
Member
Author
Contributor
There was a problem hiding this comment.
intersting message, not sure what it has to do with this code though...
Contributor
There was a problem hiding this comment.
also, why not use self.log?
Member
Author
There was a problem hiding this comment.
urgh, copy-paste fail, will fix
Member
|
Looks fine. Why the rename? |
Member
Author
|
@wpoely86: camel case must die |
|
Test PASSed. |
Member
Author
|
@wpoely86: or, more formally, |
Member
Author
boegel
added a commit
that referenced
this pull request
Nov 7, 2014
deprecate self.moduleGenerator in favor of self.module_generator in EasyBlock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will need an update in the easyblocks too, to avoid triggering deprecated code, see easybuilders/easybuild-easyblocks#506