Skip to content

support use of %(DEFAULT_ROBOT_PATHS)s template in EasyBuild configuration files#1100

Merged
boegel merged 5 commits intoeasybuilders:developfrom
boegel:robot_path_cst
Dec 3, 2014
Merged

support use of %(DEFAULT_ROBOT_PATHS)s template in EasyBuild configuration files#1100
boegel merged 5 commits intoeasybuilders:developfrom
boegel:robot_path_cst

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 28, 2014

This is required to provide users full control over which robot paths are used, while retaining the possibility of using the installed easyconfig files as a fallback (or not).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 28, 2014

@stdweird: only supporting the %(DEFAULT_ROBOT_PATHS)s template in configuration files feels a bit weird...

What's stopping us from also supporting this on the level of environment variables or even command line options, exactly?

I (briefly) tried figuring out where to handle this in generaloption.py, but ...

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

Comment thread easybuild/tools/options.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does probably not do what it you think it does. it will override any predefined DEFAULT section completly

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will fix

@stdweird
Copy link
Copy Markdown
Contributor

stdweird commented Dec 2, 2014

it would be a lot of work, dunno what the added value would (esp. in the case of the robot-paths).
otherwise it will be easier to add a append-default-root-path boolean option to do this.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 3, 2014

remark fixed and added --avail-cfgfile-constants, please rereview

I've been giving supporting this through env vars and cmdline options a bit more thought, and it's probably OK for now to not support it. I'll make sure it's clear in the documentation that the templating is only supported in config files.

@hpcugentbot
Copy link
Copy Markdown

Test FAILed.

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

Comment thread easybuild/tools/options.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not self?

@hpcugentbot
Copy link
Copy Markdown

Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 3, 2014

remarks fixed, Jenkins is happy, thanks for the review @stdweird

I'll get all the stuff w.r.t. --robot and --robot-paths documented ASAP

boegel added a commit that referenced this pull request Dec 3, 2014
support use of %(DEFAULT_ROBOT_PATHS)s template in EasyBuild configuration files
@boegel boegel merged commit 710ab26 into easybuilders:develop Dec 3, 2014
@boegel boegel deleted the robot_path_cst branch December 3, 2014 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants