only trip deprecation if extensions filter still relies on 'name'/'version' keys#1119
Merged
boegel merged 3 commits intoeasybuilders:developfrom Dec 18, 2014
Merged
only trip deprecation if extensions filter still relies on 'name'/'version' keys#1119boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
Member
|
looks great |
|
Test FAILed. |
Member
Author
|
(ignore fail tests, I aborted the intermediate test to speed things up) |
Contributor
There was a problem hiding this comment.
this has to be reformulated like "will try to see if it can be fixed with name/version" because if it fails due to something else, it will raise the actual error
Member
Author
There was a problem hiding this comment.
ok, fixing that, thx for the review
|
Test FAILed. |
|
Test PASSed. |
Member
Author
boegel
added a commit
that referenced
this pull request
Dec 18, 2014
only trip deprecation if extensions filter still relies on 'name'/'version' keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pescobar, @wpoely86: please review
this should have been part of #1107, but I missed it