Problem with timeout being considered a String#1242
Problem with timeout being considered a String#1242boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
|
@rjeschmi: the Python docs (https://docs.python.org/2/library/urllib2.html#urllib2.urlopen) aren't very clear of the type, but casting it to a float is the better option imho, to avoid tripping over a values like The unit tests should be enhanced to trigger the (now fixed) problem, I'll send a PR your way to tackle that. |
|
Refer to this link for build results (access rights to CI server needed): |
…ng a possible None value to a float
There was a problem hiding this comment.
this doesn't work, since now you'll run into a crash without specifying a timeout (since the default value is None)
fixed in rjeschmi#1
fix value type of --download-timeout in options.py + enhanced unit test
|
Refer to this link for build results (access rights to CI server needed): |
|
Going in, thanks for the fix @rjeschmi! |
Problem with timeout being considered a String
I needed this quick patch to get the download-timeout to work
should it be an int? the error was download_timeout not a Float was the only reason I did it this way.