get rid of $PROFILEREAD hack when running commands, not needed anymore#1264
Merged
boegel merged 1 commit intoeasybuilders:developfrom Apr 23, 2015
Merged
get rid of $PROFILEREAD hack when running commands, not needed anymore#1264boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
I think it should stay there, but be disabled by default on SLES. You might need this at some point in time. So just wrap it in a default disabled configure option would be preferable, imho. |
Member
Author
|
The only reason we would ever need this (again) is if we need the Besides, removing it from the code doesn't mean we lose it, it's in the git history after all. |
Contributor
|
Yes, also that it assumes that modules.sh is the file that needs to be sourced is problematic in itself. OK, lets get rid of this then. |
Member
|
looks fine |
Member
Author
|
Thanks for the feedback! Let's get rid of this cruft... |
boegel
added a commit
that referenced
this pull request
Apr 23, 2015
get rid of $PROFILEREAD hack when running commands, not needed anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to make sure that
/etc/profile.d/modules.shwas being resources on every command being executed when$PROFILEREADwas defined (i.e. on SuSE Linux systems).The only reason why this was needed was to make sure that the
modulefunction is defined in the environment in which the command is being executed.However, we don't rely on
moduleat all, so there's no longer any need for this.@pforai: feedback, since you guys are running SuSE?