Skip to content

add support for specifying and using external modules metadata (REVIEW)#1265

Merged
boegel merged 11 commits intoeasybuilders:developfrom
boegel:external_modules_metadata
Apr 25, 2015
Merged

add support for specifying and using external modules metadata (REVIEW)#1265
boegel merged 11 commits intoeasybuilders:developfrom
boegel:external_modules_metadata

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 23, 2015

No description provided.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1651/
Test FAILed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment to explain what this is about (and maybe also the ones above). it seems like magic here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename this to prefix (and add a comment)

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1653/
Test FAILed.

@boegel boegel changed the title add support for specifying and using external modules metadata (WIP) add support for specifying and using external modules metadata (REVIEW) Apr 23, 2015
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 23, 2015

@stdweird: ready for re-review; this works as expected, I was able to build WRF on top of the Cray-provided cray-hdf5-parallel and cray-netcdf when combining this with #1234

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1654/
Test FAILed.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1655/
Test PASSed.

@pforai
Copy link
Copy Markdown
Contributor

pforai commented Apr 23, 2015

Totally like it!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then call it external_prefix (way too general otehrwise)

@stdweird
Copy link
Copy Markdown
Contributor

@boegel not ok until there's documentation for the added options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants