Skip to content

fix generate_software_list.py script#1273

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:fix_generate_software_list
May 18, 2015
Merged

fix generate_software_list.py script#1273
boegel merged 3 commits intoeasybuilders:developfrom
boegel:fix_generate_software_list

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 3, 2015

No description provided.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1689/
Test PASSed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 3, 2015

merging in as trivial

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 3, 2015

or hmm, hold on, why didn't the unit test for this script catch that it's broken?!

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 18, 2015

unit tests didn't catch this because none of the test easyconfigs includes a dependency marked as an external module, fixing that...

boegel added a commit to boegel/easybuild-framework that referenced this pull request May 18, 2015
@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1715/
Test PASSed.

@wpoely86
Copy link
Copy Markdown
Member

looks fine

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 18, 2015

Thanks @wpoely86 for the review!

boegel added a commit that referenced this pull request May 18, 2015
@boegel boegel merged commit 670c13f into easybuilders:develop May 18, 2015
@boegel boegel deleted the fix_generate_software_list branch May 18, 2015 12:26
boegel added a commit to boegel/easybuild-framework that referenced this pull request May 18, 2015
…e_list

fix generate_software_list.py script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants