exclude 'easyblocks' pkg from sys.path, make sure $EASYBUILD_BOOTSTRAP* env vars are undefined via pop#1289
Merged
boegel merged 1 commit intoeasybuilders:developfrom May 27, 2015
Conversation
…P* env vars are undefined via pop
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel I can confirm that the script fixes the issues I had with bootstrapping 2.1.1 on my laptop |
Member
|
looks fine |
Member
Author
|
Thanks for the review @wpoely86, and @berndmohr for confirming the fix! Going in... |
boegel
added a commit
that referenced
this pull request
May 27, 2015
exclude 'easyblocks' pkg from sys.path, make sure $EASYBUILD_BOOTSTRAP* env vars are undefined via pop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setup.pyof easybuild-easyblocks import directly from theeasyblockspackage (see below), so any paths providing this namespace should also be excluded from the Python search path prior to initiating the bootstrap procedure.The
$EASYBUILD_BOOTSTRAP*environment variables must be unset, since they are not valid EasyBuild configuration options, which EasyBuild trips over since v2.1.0 (see #1253).