Skip to content

fix issue with cleaning up (no) logfile if --logtostdout/-l is used#1298

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_logtostdout
Jun 15, 2015
Merged

fix issue with cleaning up (no) logfile if --logtostdout/-l is used#1298
boegel merged 1 commit intoeasybuilders:developfrom
boegel:fix_logtostdout

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 15, 2015

This problem surfaces since hpcugent/vsc-base#177 was merged into vsc-base:

======================================================================
ERROR: test_zzz_logtostdout (__main__.CommandLineOptionsTest)
Testing redirecting log to stdout.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/kehoste/work/easybuild-framework/test/framework/options.py", line 333, in test_zzz_logtostdout
    out = self.eb_main([toy_ecfile, '--debug', '-l', '--force'], raise_error=True)
  File "test/framework/utilities.py", line 232, in eb_main
    raise myerr
AttributeError: 'NoneType' object has no attribute 'rfind'

----------------------------------------------------------------------
Ran 1 test in 2.069s

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1773/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1773/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@JensTimmerman
Copy link
Copy Markdown

ok for me

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 15, 2015

Thanks for the review @JensTimmerman!

boegel added a commit that referenced this pull request Jun 15, 2015
fix issue with cleaning up (no) logfile if --logtostdout/-l is used
@boegel boegel merged commit eb27aaf into easybuilders:develop Jun 15, 2015
@boegel boegel deleted the fix_logtostdout branch June 15, 2015 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants