add --read-only-installdir and --group-writable-installdir configuration options#1304
add --read-only-installdir and --group-writable-installdir configuration options#1304boegel merged 6 commits intoeasybuilders:developfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
I looked at this and the code looks ok to me, haven't tested it though... |
|
@JensTimmerman (or maybe @wpoely86): quick review? @ocaisa: I want to look into adding a simply test for verifying that this does what it's supposed to before I merge this in. |
There was a problem hiding this comment.
why doesn't this function return the result of the config option?
There was a problem hiding this comment.
it could, but we already have the build_option function that serves this purpose, this placeholder function predates build_option
There was a problem hiding this comment.
but this breaks the api?
Shouldn't you deprecate this function, and let it return the result of the config build option?
There was a problem hiding this comment.
I could, but this is not considered to be part of the 'external' API, i.e. what easyblocks should be using. So it's OK to drop this.
|
ok |
…t test for --read-only-install and --group-writable-installdir
|
looks fine |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1881/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks for the review @JensTimmerman and @rjeschmi! |
add --read-only-installdir and --group-writable-installdir configuration options
fixes #1303