Skip to content

fix dumping of hidden deps#1354

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:dump_hiddendeps
Aug 14, 2015
Merged

fix dumping of hidden deps#1354
boegel merged 3 commits intoeasybuilders:developfrom
boegel:dump_hiddendeps

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 13, 2015

fix for #1350

cc @ocaisa

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2015

@rjeschmi, @wpoely86: please review?

@boegel boegel mentioned this pull request Aug 13, 2015
Closed
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 13, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1966/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1966/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

wpoely86
wpoely86 reviewed Aug 13, 2015
View reviewed changes
Comment thread easybuild/framework/easyconfig/easyconfig.py Outdated
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Aug 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why initialize to None?

Copy link
Copy Markdown
Member Author

@boegel boegel Aug 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly to silence pylint, it's mostly a style issue

I want to make the actual copy in filter_hidden_deps, where dependencies is being modified (potentially)

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 13, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1967/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1967/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel modified the milestone: 2.2.1 Aug 13, 2015
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 14, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1968/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1968/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Aug 14, 2015

looks fine

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 14, 2015

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Aug 14, 2015
@boegel
Merge pull request #1354 from boegel/dump_hiddendeps
3b6899c 
fix dumping of hidden deps
@boegel boegel merged commit 3b6899c into easybuilders:develop Aug 14, 2015
@boegel boegel deleted the dump_hiddendeps branch August 14, 2015 08:52
@boegel boegel mentioned this pull request Oct 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86