Skip to content

fix --dep-graph, use all_dependencies EasyConfig class variable rather than 'dependencies' parameter#1359

Merged
boegel merged 6 commits intoeasybuilders:developfrom
boegel:fix_dep_graph
Aug 17, 2015
Merged

fix --dep-graph, use all_dependencies EasyConfig class variable rather than 'dependencies' parameter#1359
boegel merged 6 commits intoeasybuilders:developfrom
boegel:fix_dep_graph

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 15, 2015

fix for bug introduced in #1356, see also easybuilders/easybuild-easyconfigs#1870

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 15, 2015

This needs a unit test to catch that bug...

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 15, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1974/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1974/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel mentioned this pull request Aug 15, 2015
Merged
@boegel boegel mentioned this pull request Aug 15, 2015
Merged
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 15, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1976/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1976/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 15, 2015

@wpoely86, @pforai, @rjeschmi: please review?

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 15, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1977/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1977/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 15, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1978/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1978/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the 2.2.1 milestone Aug 16, 2015
@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Aug 17, 2015

looks fine

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 17, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1983/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1983/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 17, 2015

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Aug 17, 2015
@boegel
Merge pull request #1359 from boegel/fix_dep_graph
088fd04 
fix --dep-graph, use all_dependencies EasyConfig class variable rather than 'dependencies' parameter
@boegel boegel merged commit 088fd04 into easybuilders:develop Aug 17, 2015
@boegel boegel deleted the fix_dep_graph branch August 17, 2015 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86