Skip to content

fix EasyConfig.all_dependencies definition, fix tracking of job dependencies#1361

Merged
boegel merged 5 commits intoeasybuilders:developfrom
boegel:fix_job_deps
Aug 17, 2015
Merged

fix EasyConfig.all_dependencies definition, fix tracking of job dependencies#1361
boegel merged 5 commits intoeasybuilders:developfrom
boegel:fix_job_deps

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 16, 2015

More unanticipated fallout from dropping unresolved_deps in #1356...

The unit tests have been enhanced to make sure we don't fuck up again like this.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 16, 2015

@rjeschmi, @wpoely86, @pforai: please review?

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 16, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1980/
EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1980/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
fix breaking generate_software_list.py script because of suffix_modul…
f8ba3d0 
…es_path build option incorrectly being set to None
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Aug 16, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1981/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1981/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Aug 17, 2015

looks fine

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 17, 2015

Thanks for the review @wpoely86!

@boegel boegel added this to the 2.2.1 milestone Aug 17, 2015
boegel added a commit that referenced this pull request Aug 17, 2015
@boegel
Merge pull request #1361 from boegel/fix_job_deps
38ed610 
fix EasyConfig.all_dependencies definition, fix tracking of job dependencies
@boegel boegel merged commit 38ed610 into easybuilders:develop Aug 17, 2015
@boegel boegel deleted the fix_job_deps branch August 17, 2015 08:19
@boegel boegel mentioned this pull request Aug 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @hpcugentbot @wpoely86