Skip to content

fix 'exist' for hidden Lua module files#1364

Merged
boegel merged 5 commits intoeasybuilders:developfrom
boegel:fix_exist_hidden_lua_module
Aug 18, 2015
Merged

fix 'exist' for hidden Lua module files#1364
boegel merged 5 commits intoeasybuilders:developfrom
boegel:fix_exist_hidden_lua_module

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 18, 2015

fix for #1340

Existence of hidden modules is checked via module show, and then checking whether the module file path matches with the module name.

The regex wasn't taking into account that the module file path may have a .lua extension for hidden Lua module files.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 18, 2015

@pforai: up for giving this a review, since you're familiar with this?

@boegel boegel added this to the 2.2.1 milestone Aug 18, 2015
@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1985/
EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1985/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@pforai
Copy link
Copy Markdown
Contributor

pforai commented Aug 18, 2015

LGTM!

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1987/
EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1987/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1988/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1988/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 18, 2015

Thanks for the review @pforai, and @riccardomurri for reporting the bug!

boegel added a commit that referenced this pull request Aug 18, 2015
fix 'exist' for hidden Lua module files
@boegel boegel merged commit 421c398 into easybuilders:develop Aug 18, 2015
@boegel boegel deleted the fix_exist_hidden_lua_module branch August 18, 2015 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants