add support for --review-pr (REVIEW) by boegel · Pull Request #1383 · easybuilders/easybuild-framework

boegel · 2015-09-04T20:05:27Z

replacement for #1142 which was targeting the wrong branch, I'll tackle the remarks made there.

continued where @nudded's left off with #1005

It contains a bunch of cleanups on top of @nudded's work, together with code style cleanup.

boegel · 2015-09-07T05:41:45Z

Jenkins: test this please

hpcugentbot · 2015-09-07T06:23:22Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2020/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2020/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-09-07T07:31:57Z

Should be almost good to go, major thing missing is some unit tests...

hpcugentbot · 2015-09-07T08:13:19Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2021/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2021/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

…github.py

hpcugentbot · 2015-09-09T18:32:17Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2026/
EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2026/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-10T08:35:22Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2027/
EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2027/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-10T09:05:16Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2028/
EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2028/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-10T10:12:32Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2029/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2029/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-10T11:28:07Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2030/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2030/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-09-10T11:34:39Z

This is a reviewed version of #1005 by @nudded, which has already been reviewed via #1142.

Unit tests have been added to cover the new functionality, so this is good to go in (finally!).

Thanks @nudded for putting this together, and everyone else who contributed in one way or another!

add support for --review-pr (REVIEW)

Toon Willems added 30 commits August 13, 2014 10:37

add download_repo() method

dbed38c

compare push

b3eef1f

change outputter

7dbbffb

add tool to determine terminal size

839e716

don't need no ordering

422f5d1

some minor fixes

01325ee

fix exact matching

e7f0386

move review code to dedicated module

f92fffb

add SO reference to terminal.py

fc672b6

improve logging, make download_repo generic

e3c3255

cleanup find_related_easyconfigs

e4be300

add header, general cleanup of multi_diff

31b43d3

remove unneeded whitespace in main.py

587976b

use setdefault, __str__

5fb9d5d

change to positive logic

88f118b

use constant instead of random strings

10d5256

add header, note about failing imports

bdc096c

creative use of setdefault

7daded0

wrap long line

994f3eb

remove 2/3 _download references

fe05cf1

cleanup sorting / filtering

ce87340

cleanup ifs

f80be4e

fix colorize

702c811

add support to disable colors

9b69d78

add check for not redownloading github archive

841cc44

add some docstrings

78bd67e

change some docstrings around

27d2709

syntax error

30a2774

copyright year

2ef71c0

fix all the things

46ca7e3

boegel added 2 commits September 7, 2015 09:08

Merge branch 'develop' into feature/add-review-pr-option

51baaf7

fix remarks

2def984

boegel changed the title ~~add support for --review-pr (WIP)~~ add support for --review-pr (REVIEW) Sep 7, 2015

boegel added 9 commits September 9, 2015 14:43

fix debug log statements w.r.t. regex

70de7fe

fix patterns without toolchain name/version (exclude '-', use *)

58e1aeb

add unit test for find_related_easyconfigs

47e2e1c

move det_terminal_size to systemtools.py

945dd2e

add unit test for det_terminal_size

669f63b

add unit test for multidiff function

60fdae0

fix bugs in download_repo

b12c7e6

add tests for fetch_latest_commit_sha and download_repo functions in …

f9bd146

…github.py

add unit test for --review-pr

d88c3c2

boegel added 2 commits September 10, 2015 10:26

sort result of find_related_easyconfigs

d731300

make det_terminal_size more robust, fix order of values in result

32edb87

fix height/width order in det_terminal_size

f5357fd

fix multidiff unit test w.r.t. small terminal width

5ff9390

remove intel-taito.py toolchain definition that slipped in

f991282

boegel added a commit that referenced this pull request Sep 10, 2015

Merge pull request #1383 from boegel/feature/add-review-pr-option

452674c

add support for --review-pr (REVIEW)

boegel merged commit 452674c into easybuilders:develop Sep 10, 2015

boegel deleted the feature/add-review-pr-option branch September 10, 2015 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for --review-pr (REVIEW)#1383

add support for --review-pr (REVIEW)#1383
boegel merged 72 commits intoeasybuilders:developfrom
boegel:feature/add-review-pr-option

boegel commented Sep 4, 2015

Uh oh!

boegel commented Sep 7, 2015

Uh oh!

hpcugentbot commented Sep 7, 2015

Uh oh!

boegel commented Sep 7, 2015

Uh oh!

hpcugentbot commented Sep 7, 2015

Uh oh!

hpcugentbot commented Sep 9, 2015

Uh oh!

hpcugentbot commented Sep 10, 2015

Uh oh!

hpcugentbot commented Sep 10, 2015

Uh oh!

hpcugentbot commented Sep 10, 2015

Uh oh!

hpcugentbot commented Sep 10, 2015

Uh oh!

boegel commented Sep 10, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

boegel commented Sep 4, 2015

Uh oh!

boegel commented Sep 7, 2015

Uh oh!

hpcugentbot commented Sep 7, 2015

Uh oh!

boegel commented Sep 7, 2015

Uh oh!

hpcugentbot commented Sep 7, 2015

Uh oh!

hpcugentbot commented Sep 9, 2015

Uh oh!

hpcugentbot commented Sep 10, 2015

Uh oh!

hpcugentbot commented Sep 10, 2015

Uh oh!

hpcugentbot commented Sep 10, 2015

Uh oh!

hpcugentbot commented Sep 10, 2015

Uh oh!

boegel commented Sep 10, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants