fix checking of sanity check paths w.r.t. discriminating between files and directories#1436
Merged
boegel merged 2 commits intoeasybuilders:developfrom Oct 21, 2015
Merged
Conversation
2 tasks
Member
Author
|
cfr. #1424 |
Member
Author
|
@wpoely86: please review? |
Member
|
lgtm |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2219/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Member
Author
|
Jenkins fluke? |
Member
Author
|
Jenkins: test this please |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2222/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Member
Author
|
Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Oct 21, 2015
fix checking of sanity check paths w.r.t. discriminating between files and directories
This was referenced Nov 1, 2015
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the way in which sanity check paths are checked.
The
check_fnvariable contains the function that should be used for checking files/directories specifically.In particular, this fixes: