Use diff --git lines to determine the files in PR#1460
Use diff --git lines to determine the files in PR#1460boegel merged 5 commits intoeasybuilders:developfrom
Conversation
Instead of searching for +++ lines, search for diff --git. This should be more foolproof and lead to less false positives.
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2311/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
It has a special mode for github patches now
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2314/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel please review |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2315/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
jenkins please retest |
|
Jenkins retest this please |
|
EasyBuild framework unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2317/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@boegel can you have a look at these tests? I don't understand what is causing the problem. |
|
Jenkins: test this please |
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2330/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
minor style & docstring fixes
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2394/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks @wpoely86! |
Use diff --git lines to determine the files in PR
Instead of searching for +++ lines, search for diff --git. This should
be more foolproof and lead to less false positives.
easybuilders/easybuild-easyconfigs#2126 is an example where the previous regex failed.